Repository navigation
refactor: match the Your First App docs - #112
Open
brandyscarney wants to merge 1 commit into
Open
brandyscarney wants to merge 1 commit into
brandyscarney wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Makes the app's code match what a reader ends up with after following the "Your First App" docs, so the repo can be used to check your work against the tutorial.
New Behavior
None. The app works the same; only comments and one unused starter property change.
Changes
photo.service.ts: comments now match the docs. The old/* Use the device camera ... */block (with dead capacitor.ionicframework.com links) and other comments the docs don't have are removed; the inline comments on theCamera.getPhotooptions stay, since the docs now have them too, and thedeletePhotocomments use the docs' wording.tabs.page.ts: matches the starter plus the docs' change (registering theimagesicon), including the starter'senvironmentInjector.main.ts: removes a comment that is a// CHANGE:marker in the docs, not code.Notes
tabs.page.tsstep, so a reader got a blank tab icon after switching toimages. docs: align tutorial, quickstart, and testing pages with the updated starters ionic-docs#4805 adds it.SplashScreen.hide()inmain.ts, the Capacitor splash screen config, the PWA manifest, and the native projects and assets.