Repository navigation
refactor: match the Your First App docs - #81
Open
brandyscarney wants to merge 1 commit into
Open
brandyscarney wants to merge 1 commit into
brandyscarney wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
chore/match-docs
branch
from
October 26, 2026 15:33
53368c3 to
ad49ff5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Makes the app's code match what a reader ends up with after following the "Your First App" docs, so the repo can be used to check your work against the tutorial.
New Behavior
None. The app works the same; names, declaration order, and comments change to match the docs.
Changes
usePhotoGallery.ts:takePhoto→addNewToGallery,photo→capturedPhoto,savedFileImage→savedImageFile.PHOTO_STORAGEandbase64FromPathmove inside the hook, and the functions are declared in the docs' order.deletePhotouses.slice()instead of the deprecated.substr().savePicturepasses the photo data fromFilesystem.readFile()straight toFilesystem.writeFile()(string | Blob), like the Angular app, instead of converting a Blob with.text(), which would have saved raw bytes as if they were base64.Camera.getPhotooptions.Tab2.tsx: usesaddNewToGallery,<IonContent fullscreen>, and the docs' Cancel handler and action sheet markup.addNewToGalleryrename, and the native Blob test now checks the data reacheswriteFileunchanged.Notes
SplashScreen.hide()inmain.tsx, the Capacitor splash screen config, and the native assets.