Repository navigation
Fix differential-phase mask arguments and expand ionosphere test coverage - #412
Merged
oberonia78 merged 5 commits intoOct 7, 2026
Merged
Conversation
hfattahi
requested review from
bhawkins,
hfattahi,
seongsujeong and
xhuang-jpl
October 6, 2026 16:03
xhuang-jpl
reviewed
Oct 6, 2026
Comment on lines
+1014
to
+1017
| first_mask_path = f"{dest_freq_path}/interferogram/mask" | ||
| second_data_path = first_data_path | ||
| second_mask_path = f"{dest_freq_path}/interferogram/mask" | ||
| second_valid_mask_paths = first_valid_mask_paths |
Contributor
There was a problem hiding this comment.
Suggested change
| first_mask_path = f"{dest_freq_path}/interferogram/mask" | |
| second_data_path = first_data_path | |
| second_mask_path = f"{dest_freq_path}/interferogram/mask" | |
| second_valid_mask_paths = first_valid_mask_paths | |
| first_mask_path = f"{dest_freq_path}/interferogram/mask" | |
| second_data_path = first_data_path | |
| second_mask_path = first_mask_path | |
| second_valid_mask_paths = first_valid_mask_paths |
bhawkins
approved these changes
Oct 6, 2026
| ("ionosphere_main_side_test.yaml", "main_diff_ms_band"), | ||
| ], | ||
| ) | ||
| def test_ionosphere_run(yaml_name, method, tmp_path, monkeypatch): |
Contributor
There was a problem hiding this comment.
How are tmp_path and monkeypatch populated? I don't see them in the parameter list.
Contributor
Author
There was a problem hiding this comment.
tmp_path and monkeypatch are built-in pytest fixtures.
xhuang-jpl
approved these changes
Oct 6, 2026
xhuang-jpl
left a comment
xhuang-jpl
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @oberonia78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
main_diff_low_high_subbandworkflow omitted the requiredfirst_valid_mask_pathsandsecond_valid_mask_pathsarguments when callingcompute_differential_phase(), causing a TypeError.This PR supplies the polarization-specific validity-mask paths, fallback subswath-mask paths, and masking flag. When masking is enabled, each input uses validDataMask when available and falls back to the shared mask otherwise.
The test updates: