Repository navigation
Conversation
…ffsets and offsets product
… pycuampcor supports it
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces isce3's internal copies of pycuampcor with the standalone pycuampcor package (https://github.com/earthdef/cuAmpcor, release 2.2.0): one code base with a CUDA backend (
PyCuAmpcor) and a multi-threaded (OpenMP) CPU backend (PyCPUAmpcor). #410 fixes the internal copies, so that the switch can be checked bit for bit.Changes
cxx/isce3/{,cuda/}matchtemplate/pycuampcorare removed. For compatibility,isce3.matchtemplateandisce3.cuda.matchtemplatere-exportPyCPUAmpcorandPyCuAmpcorfrom the package.runAmpcorLayers): each image chunk is loaded once for all layers. With an older pycuampcor, the layers run one at a time as before.HDF5:<file>:<dataset>), so the ENVI copy is no longer made. It is still made for complex32 data or an older pycuampcor without HDF5 support.windows_batch_range/windows_batch_azimuthmay be empty or 0 (now the default), meaning (SM/4) x 8 windows on the GPU (e.g., 20 x 8 on a V100, 27 x 8 on an A100) and 1 x 1 on the CPU.cross_correlation_workflow(two_pass, the default, orone_pass) for dense_offsets and offsets_product.environment.ymlrequirespycuampcor>=2.2.Results
Dependency and CI
environment.ymladds the anaconda.org channellijun99. It holds the same recipe, built for the conda-forge variants by a GitHub Actions workflow in earthdef/cuAmpcor: cpu, and CUDA 12.9, 13.0 and 13.4, for linux-64/aarch64 and osx-64/arm64, Python 3.11-3.14. The channel can be removed once the package is on conda-forge.Testing
The CI jobs were reproduced in fresh environments created from this branch's
environment.yml, so pycuampcor was installed from thelijun99channel. Each build was installed and the CI tests run serially, as in the workflows (ctest -E ".*(stage_dem|pybind\.unwrap\.phass)").conda install -c nvidia cuda, CUDA 13.3;WITH_CUDA,RelWithDebInfo): the environment gets the CUDA build of pycuampcor (cuda130).Debug): the environment gets the cpu build of pycuampcor.With #411, all tests pass in both jobs.