Skip to content

Fix sweets config examples and README Workflow snippet - #159

Open
JakobKlotz wants to merge 2 commits into
isce-framework:mainfrom
JakobKlotz:config-cmd-fix
Open

JakobKlotz wants to merge 2 commits into
isce-framework:mainfrom
JakobKlotz:config-cmd-fix

Conversation

@JakobKlotz

Copy link
Copy Markdown

Hi, thanks for the great tool! While running the examples I hit a couple of small issues. I figured to propose some small changes.

  • CLI examples: sweets config --bbox=... fails to parse because of the =. I changed all examples to --bbox ....
  • README: The Workflow example can't be instantiated because pydantic validation of BurstSearch fails when bbox is missing. I added the bbox to the example.

@scottstanie scottstanie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants