Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions apps/mobile/src/components/agents/child-session-message.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ describe('ChildSessionMessage routing seam', () => {
});
});

describe('ChildSessionSection model label', () => {
it('renders the model label when child messages carry model data', () => {
describe('ChildSessionSection card metadata', () => {
it('does not render a transcript-derived model label on the card', () => {
const childMessages = [makeMessage([makeTextPart('child text')])];
const onOpenChildSession = vi.fn<(sessionId: string, title: string) => void>();
const part = makeToolPart('task', taskCompletedState);
Expand All @@ -253,23 +253,6 @@ describe('ChildSessionSection model label', () => {
onOpenChildSession,
});

const labels = findByType(root, ChildSessionModelLabel);
expect(labels).toHaveLength(1);
expect(labels[0]?.props).toMatchObject({ modelLabel: 'Test Model' });
});

it('hides the model label when child messages are empty and still renders the card', () => {
const onOpenChildSession = vi.fn<(sessionId: string, title: string) => void>();
const part = makeToolPart('task', taskCompletedState);

// eslint-disable-next-line new-cap, react-compiler-runtime/react-compiler-runtime -- direct function call
const root = ChildSessionSection({
part,
childMessages: [],
modelOptions: [modelOption],
onOpenChildSession,
});

expect(findByType(root, ChildSessionModelLabel)).toHaveLength(0);
const taskNameTexts = findAll(
root,
Expand Down
8 changes: 0 additions & 8 deletions apps/mobile/src/components/agents/child-session-section.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import {
getChildSessionCardState,
getTaskToolSessionId,
} from './child-session-card-state';
import { getChildSessionModelLabel } from './child-session-model';
import { ChildSessionModelLabel } from './child-session-model-label';
import { MessageErrorBoundary } from './message-error-boundary';
import { isToolPart } from './part-types';

Expand Down Expand Up @@ -55,16 +53,12 @@ type ChildSessionSectionProps = {

export function ChildSessionSection({
part,
childMessages,
onOpenChildSession,
modelOptions,
}: Readonly<ChildSessionSectionProps>) {
const colors = useThemeColors();
const { t } = useTranslation();

const { agentName, taskName, status }: ChildSessionCardState = getChildSessionCardState(part);
const modelLabel =
childMessages.length > 0 ? getChildSessionModelLabel(childMessages, modelOptions ?? []) : null;

const isRunning = status === 'running' || status === 'pending';
const sessionId = getTaskToolSessionId(part);
Expand All @@ -90,7 +84,6 @@ export function ChildSessionSection({
accessibilityLabel={t('agentChat.childSession.accessibilityLabel', {
agentName,
taskName,
modelLabel: modelLabel ? `, ${modelLabel}` : '',
status: t(CHILD_SESSION_STATUS_LABEL_KEYS[status]),
})}
accessibilityHint={sessionId ? t('agentChat.childSession.openHint') : undefined}
Expand All @@ -111,7 +104,6 @@ export function ChildSessionSection({
<Text className="text-sm leading-5 text-foreground" numberOfLines={1}>
{taskName}
</Text>
{modelLabel ? <ChildSessionModelLabel modelLabel={modelLabel} /> : null}
</View>

<StatusBadge status={status} />
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/af.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/am.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/ar.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/az.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/be.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/bg.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/bn.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/bs.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/ca.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/ckb.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/cs.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/cy.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/da.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/de.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/el.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -2475,7 +2475,7 @@
"waitingForPermission": "The agent is waiting for permission. While this request is open, your message to the agent is paused."
},
"childSession": {
"accessibilityLabel": "{{agentName}}, {{taskName}}{{modelLabel}}, {{status}}",
"accessibilityLabel": "{{agentName}}, {{taskName}}, {{status}}",
"maxNestingDepth": "Maximum nesting depth reached.",
"modelAccessibility": "Model: {{modelLabel}}",
"openHint": "Open subagent session",
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/es.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/et.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/eu.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/fa.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/fi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/fil.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/fr.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/ga.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/gl.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/gu.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/ha.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/he.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/hi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/mobile/src/i18n/locales/hr.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading