Repository navigation
19 Update to AsciidoctorJ 3.0.1 - #29
sophokles73 wants to merge 4 commits into
Conversation
Replaced invocations of StructuralNode.findBy() with manual traversal of child nodes because findBy() seems to be broken in AsciidoctorJ 3.0.1. This should not have much impact on runtime efficiency because findBy() would have to traverse the child nodes anyway, and we only care about direct children anyway, whose number should usually be quite small.
sophokles73
added
bug
kaklakariada
left a comment
kaklakariada
left a comment
There was a problem hiding this comment.
I would change the log level to finest, but if you prefer to keep finer, that's OK for me.
|
The link checker fails, because some URLs are not valid any more: =========================> MARKDOWN LINK CHECK <========================= ERROR: 1 dead link found in ./doc/developer_guide.md ! ERROR: 2 dead links found in ./README.md ! |
|
@kaklakariada would you mind taking another look? |
kaklakariada
left a comment
kaklakariada
left a comment
There was a problem hiding this comment.
Thanks a lot for your changes!
|
Sorry, another thing: sonar does not run on this pr because it comes from a fork and has no access to the sonar token. You should have permissions to push the branch to this repo. Could you please create another PR? |
2 participants
Replaced invocations of StructuralNode.findBy() with manual traversal of child nodes because findBy() seems to be broken in AsciidoctorJ 3.0.1.
This should not have much impact on runtime efficiency because findBy() would have to traverse the child nodes anyway, and we only care about direct children anyway, whose number should usually be quite small.