Fix all-day events missing from date-grouped output - #22
Merged
Merged
Conversation
EventKit ends all-day events at 23:59:59 of the last day, not midnight of the next day, so single-day all-day events were dropped entirely and multi-day ones lost their final day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All-day events were missing from output whenever results were grouped by date, which is the default for multi-day ranges (e.g.
--from today --to today+60).DateGrouperassumed EventKit ends all-day events at midnight of the next day and subtracted a day. EventKit actually ends them at 23:59:59 of the last day, so single-day all-day events were dropped entirely and multi-day ones lost their final day.Days are now bucketed by
endDate - 1s(never beforestartDate), which handles both end conventions and timed events ending exactly at midnight. Added tests using EventKit's real end-date shape.Relates to #20