Fix notes never rendering in text output - #23
Merged
Merged
Conversation
The default event template never referenced notes, so show-notes and --hide notes had no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #21
The default event template never referenced
{{notes}}, soshow-notes = trueand--hide noteshad no effect on text output. Notes only appeared in JSON.This adds a Notes section to the default template, after Attendees and before Recurs. It's still off by default (
show-notes = false).Notes:label via a new{{{indentedNotes}}}template variable. Both LF and CRLF line endings work, and blank lines get no trailing whitespace.<b>is not turned into<b>.truncate-notesstill applies.Example with
show-notes = true:Not in this PR: the
--hide recurrence/show-recurrencetoggle and stripping HTML from notes.