Repository navigation
Conversation
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04bbaf21b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TF_INPUT: "0" | ||
| TF_IN_AUTOMATION: "1" | ||
| TF_PLUGIN_CACHE_DIR: ${{ runner.temp }}/velnor/tofu-cache/b3-d1e3f385428fcc1037c389c08e5fe9a9d4b2ca17c65809c27574ef265fc7708b | ||
| run: "env -u ACTIONS_ID_TOKEN_REQUEST_TOKEN -u ACTIONS_ID_TOKEN_REQUEST_URL -u ACTIONS_RUNTIME_TOKEN -u GITHUB_TOKEN -u MISE_GITHUB_TOKEN -u GH_TOKEN -u GH_HOST -u GH_CONFIG_DIR mise --no-config --no-env --no-hooks exec 'opentofu@'\"${VELNOR_TOOL_OPENTOFU}\" -- init -backend=false -input=false -lockfile=readonly -no-color" |
There was a problem hiding this comment.
Invoke
tofu init in the provider producer
On a protected-default-branch push where the provider cache misses, this step asks Mise to execute the command init, not the selected OpenTofu binary: mise exec --help defines the arguments after -- as the subprocess command, and the corresponding task at line 451 correctly uses -- tofu init. The host's init therefore fails on these flags, success() becomes false, and the continue-on-error producer never reaches actions/cache/save, leaving every later run cold. Correct this in the upstream generator and regenerate the managed workflow.
AGENTS.md reference: .github/AGENTS.md:L17-L20
Useful? React with 👍 / 👎.
| id: verify | ||
| shell: /bin/bash --noprofile --norc -p -e -o pipefail {0} | ||
| env: | ||
| VELNOR_TOOL_PINS: "jactionlint 2.4.0 linux-arm64 https://github.com/jdx/jactionlint/releases/download/v2.4.0/jactionlint_2.4.0_linux_arm64.tar.gz 42413391c248f99ff4550d6c866ee717d5ea4ca2b966d9d54ad1503af955e22f\njactionlint 2.4.0 linux-x64 https://github.com/jdx/jactionlint/releases/download/v2.4.0/jactionlint_2.4.0_linux_amd64.tar.gz 26ddba81db28fffc51163175c070ee1a9d1150260de4b5232f01d9b749f32d8e\njactionlint 2.4.0 macos-arm64 https://github.com/jdx/jactionlint/releases/download/v2.4.0/jactionlint_2.4.0_darwin_arm64.tar.gz 349a13dbffdd25376898a256d195806afda08ba97ccc6378cbf2dd11a77ef8e7\njactionlint 2.4.0 macos-x64 https://github.com/jdx/jactionlint/releases/download/v2.4.0/jactionlint_2.4.0_darwin_amd64.tar.gz 4c21fce834f8267b65a65b32a527aaa2ec1c321c8f066d44b42d7f038835aa90\nhttp-cargo-machete 0.9.2 linux-x64 https://github.com/bnjbvr/cargo-machete/releases/download/v0.9.2/cargo-machete-v0.9.2-x86_64-unknown-linux-musl.tar.gz 48200087f54c55aabcd4db4af1e25742b49846c02a1b1bfa134711945b35b2e9\nhttp-lychee 0.15.1 linux-x64 https://github.com/lycheeverse/lychee/releases/download/v0.15.1/lychee-v0.15.1-x86_64-unknown-linux-gnu.tar.gz 9afdf0f48064fdcd8a8815ca6d2d9fcd43a0ef4c2edf9da23d6f7bf46a764eb8" |
There was a problem hiding this comment.
Add ShellCheck to the verification catalog
Whenever a restored Mise cache contains shellcheck@0.11.0, verify_install accepts it only if the tool has a matching entry in this catalog or the project mise.lock; this catalog omits ShellCheck, while the lock contains only project tools. The verifier therefore takes its no mise.lock or catalog pin path and deletes the restored ShellCheck installation before each of the workflow's subsequent mise install ... shellcheck@0.11.0 steps, defeating the new tools cache for a tool used by multiple jobs. Add ShellCheck's per-platform archive pins in the upstream generator and regenerate the managed action.
AGENTS.md reference: .github/AGENTS.md:L17-L20
Useful? React with 👍 / 👎.



Blocked by released Velnor Actions 0.1.80 task-manifest generation. This PR upgrades the exact official manifest from 0.1.12 and regenerates all owned output; a fresh preview matches byte-for-byte.
The official plan selects
stack/tofu/dir-/fmt/default,init/defaultandvalidate/default. Their workflow report wrappers exist, but.github/velnor/task-execution-manifest-v1.jsonis absent from both the generated checkout and preview. The emitted group ledger therefore cannot resolve the selected tasks. This is the same source-traced defect as ChainArgos/cloudflare-tofu run43898661398/job133409498995 and ChainArgos/github-terraform.The PR was opened before the wrapper IDs were correctly distinguished from manifest entries. A read-only manifest gate now fails on this actual artifact. Keep this PR unmerged pending a released generator fix. No generated hand edits, synthetic reports, validation bypass or generator change. Recorded evidence: official generation/preview/diff/manifest checksum pass; actual task-manifest presence check fails. This does not claim full local/hosted checks passed.
Consumer rollout tracking: tailrocks/velnor-new#934.