Repository navigation
Conversation
Each file in a flow group or the Ungrouped bucket gets its own reviewed checkbox. `x` now toggles the selected file and `X` toggles its whole group; a group is ticked once all of its files are, and ticking a group ticks every file in it. The Ungrouped bucket can be ticked like a flow group and counts toward the "n/m reviewed" total. Reviewed files are dimmed in the collapsed group rail. File ticks reset wherever group ticks reset (new analysis, refinement applied, manifest import).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a per-file reviewed checkbox in addition to the existing per-group tick.
xtoggles the selected file.Xtoggles its whole flow. The keyboard hint footer is updated.infra) can be ticked like a flow group and counts toward then/m reviewedcounter.clearAnalysis.This revives
wip/file-review-tick(2de1dd2, salvaged WIP based on v0.5.16), rebased onto currentdev. Conflicts were inclearAnalysis(dev addedshowNewCommitsandrefinementAppliedreset) and in the infra groupclassName(dev addedselected). Both sides were kept. The rail styling and the three extra reset sites are new, needed because dev added those code paths after the WIP was written.Testing
In the devShell (
nix develop),crates/diffcore-tauri/ui:npm run build(tsc + vite): passesnpm run typecheck:e2e: passesnpx playwright test, full suite: 235 passed, 2 skipped. This includes the new specs intests/e2e/bugfixes.spec.ts:xtoggles file reviewed from Monaco focusShift+Xtoggles the group and syncs files, and per-file untick/retick propagates to the groupNote: if the host shell exports
LD_LIBRARY_PATHwith a neweralsa-lib, the nix Playwright Chromium fails to launch withGLIBC_2.43 not found. Run withenv -u LD_LIBRARY_PATH nix develop .... This is unrelated to this PR.Known gaps
I(Ungrouped) chip in the collapsed rail doesn't show tick state.