Repository navigation
Make HTTP transport types public and add PATCH/PUT methods - #198
Merged
Merged
Conversation
…Method Allows external packages to build on the HTTPClient transport abstraction: - HTTPRequest.url/method/headers/body and HTTPResponse.statusCode/headers are now public - HTTPMethod gains .patch and .put (both adapters already pass rawValue through)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the platform-agnostic HTTP transport layer usable from external packages:
HTTPRequest.url/method/headers/bodyandHTTPResponse.statusCode/headersare nowpublic(previously only the initializers were).HTTPMethodgains.patchand.put. Both adapters already passrawValuestraight through, so no behavior changes.No breaking changes for existing users: the visibility change is purely additive, and nothing in the library switches exhaustively over
HTTPMethod. Suggest shipping as a minor version bump.