Repository navigation
Preserve Linux streaming lines across HTTP chunks - #200
Merged
Merged
Conversation
Retain incomplete lines and UTF-8 characters until a real delimiter so network chunk boundaries cannot corrupt decoder input. Cancel the body producer when its consumer terminates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux streaming treated arbitrary HTTP body chunks as complete lines. A JSON line or UTF-8 character split between chunks could therefore reach the consumer incomplete, and chunk boundaries could add spurious empty lines.
Buffer bytes until a real LF, CRLF or CR delimiter, retain only the pending EOF tail, read the ByteBuffer readable region, and cancel the body producer when its consumer terminates. Malformed payloads and connection errors remain errors for the caller to classify.
Validation: