Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
VectorStoreFileObject had no CodingKeys, so a valid vector-store file response failed at usageBytes and could not be read by the default service. Map usage_bytes, created_at, vector_store_id and last_error together, preserving required fields, zero usage and nullable errors. No global decoder strategy or fallback defaults change.
Validation:
swift test --force-resolved-versions: 114 tests, 0 failures. Tests cover DTO decoding plus create, retrieve, list and batch-list through OpenAIServiceFactory's default decoder and an in-memory HTTPClient. Zero/nonzero usage, null/missing/non-null errors, and required/malformed fields are covered.swift build --force-resolved-versions: passes on macOS arm64, Swift6.4 with the tracked resolved versions.Linux Swift6.0.1/6.2, iOS, hosted CI and actual PDF upload/provider processing were not tested. Fixtures require no credentials or real endpoint.
AI assistance: OpenAI Codex researched, implemented, tested and independently reviewed this fix.