add bounds check for country code table#3811
Open
ann0see wants to merge 1 commit into
Open
Conversation
ann0see
commented
Jul 20, 2026
| // Qt6 changed those IDs, so we have to convert back: | ||
| if ( iCountryCode >= qt6CountryToWireFormatLen ) | ||
| { | ||
| return QLocale::AnyCountry; |
Member
Author
There was a problem hiding this comment.
What should we return otherwise?
ann0see
commented
Jul 20, 2026
|
|
||
| if ( iIdx >= qt6CountryToWireFormatLen ) | ||
| { | ||
| return 0; |
Member
Author
There was a problem hiding this comment.
Not sure what to return...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds bounds check for qt6 country code conversion (also found like #3810 )
CHANGELOG: Add bounds checking for country code lookup
Context: Fixes an issue?
/
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review (didn't analyze this one deeply). The style follows isCountryCodeSupported. Alternatively, we could probably just call IsCountryCode supported as guard?
What is missing until this pull request can be merged?
Review, analysis.
Checklist