Repository navigation
Let the installer close a running OpenHaze - #13
Merged
Merged
Conversation
Upgrading over a running copy stopped on Setup's "applications are using files" page with a blank entry, and "Automatically close" then failed with "DeleteFile failed; code 5". Three causes, three fixes: - The exe had no file description, so Windows had no name to show. It now carries a title, product, company and copyright. - OpenHaze ignored the close request that Restart Manager sends to every top-level window. The hidden hotkey window now answers WM_QUERYENDSESSION and exits through the normal cleanup on WM_ENDSESSION, which also makes logoff clean. - installer.iss uses CloseApplications=force as a backstop, which loses nothing because settings are saved on every change, and hides "Do not close the applications", since a per-user install can only fail on that path. Also replaces the em dashes in OpenHaze.cs and NativeMethods.cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WM_QUERYENDSESSION/WM_ENDSESSION) by exiting through the normal cleanup. Restart Manager, which Setup uses, only asks top-level windows, and that window is one. Logoff is now clean as well.installer.issusesCloseApplications=forceas a backstop and hides "Do not close the applications".OpenHaze.csandNativeMethods.cs, including the tray tooltip and the About text.Why
Upgrading 0.2.1 to 0.2.2 over a running copy listed a blank entry, "Automatically close" failed ("Setup was unable to automatically close all applications"), and the install then stopped with "DeleteFile failed; code 5. Access is denied." A per-user install cannot replace a running exe or defer that to a restart, so "Do not close" could only end in the same error. Forcing the close loses nothing, because settings are saved on every change.
How it was tested
' 'and refused (RmShutdown351, still running); this build reportedOpenHaze, accepted (0) and exited with code 0.installer.isscompiles in this PR's Windows job; Inno Setup is not installed locally. The real upgrade over a running copy is tracked as B-1 in BACKLOG.md.