Repository navigation
Keep the packaged app passing strict signature checks - #14
Merged
Merged
Conversation
Hiding the .app extension in the disk image (added in #11) makes dmgbuild set a Finder flag on the bundle, and codesign --verify --deep --strict rejects that as extra metadata. So the app in the 0.2.2 dmg fails strict checks, which 0.2.1 passed. Normal verification still passed, so nothing visibly broke. The extension is visible again, and package-dmg.sh now mounts the finished image and runs the strict check, so packaging fails instead of shipping a signature that strict tools reject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dmg-settings.pyno longer hides the.appextension.package-dmg.shmounts the finished image and runscodesign --verify --deep --stricton the app, so packaging fails instead of shipping a signature strict tools reject.Why
Hiding the extension (added in #11) makes dmgbuild store a Finder flag (
com.apple.FinderInfo) on the bundle, and strict verification rejects that as extra metadata. The app in the 0.2.2 dmg fails strict checks, which 0.2.1 passed. Normal verification still passed, so nothing visibly broke, but strict-mode tools such as Homebrew's cask audit would reject it, and the flag stays on the app after it is dragged into Applications.How it was tested
On the Mac Mini with the runner's locale (
LC_ALL=en_US /bin/bash): with this change, packaging and the strict check pass; with the 0.2.2 settings, packaging now fails with the exact "resource fork, Finder information, or similar detritus not allowed" error. Thetrapunmounts the image in both cases. This PR's macOS job runs the same check on the hosted runner.