Skip to content

Keep the packaged app passing strict signature checks - #14

Merged
jay739 merged 1 commit into
mainfrom
fix/dmg-strict-signature
Nov 9, 2026
Merged

jay739 merged 1 commit into
mainfrom
fix/dmg-strict-signature

Conversation

@jay739

@jay739 jay739 commented Nov 9, 2026

Copy link
Copy Markdown
Owner

What

  • dmg-settings.py no longer hides the .app extension.
  • package-dmg.sh mounts the finished image and runs codesign --verify --deep --strict on the app, so packaging fails instead of shipping a signature strict tools reject.

Why

Hiding the extension (added in #11) makes dmgbuild store a Finder flag (com.apple.FinderInfo) on the bundle, and strict verification rejects that as extra metadata. The app in the 0.2.2 dmg fails strict checks, which 0.2.1 passed. Normal verification still passed, so nothing visibly broke, but strict-mode tools such as Homebrew's cask audit would reject it, and the flag stays on the app after it is dragged into Applications.

How it was tested

On the Mac Mini with the runner's locale (LC_ALL=en_US /bin/bash): with this change, packaging and the strict check pass; with the 0.2.2 settings, packaging now fails with the exact "resource fork, Finder information, or similar detritus not allowed" error. The trap unmounts the image in both cases. This PR's macOS job runs the same check on the hosted runner.

Hiding the .app extension in the disk image (added in #11) makes dmgbuild set
a Finder flag on the bundle, and codesign --verify --deep --strict rejects
that as extra metadata. So the app in the 0.2.2 dmg fails strict checks, which
0.2.1 passed. Normal verification still passed, so nothing visibly broke.

The extension is visible again, and package-dmg.sh now mounts the finished
image and runs the strict check, so packaging fails instead of shipping a
signature that strict tools reject.
@jay739
jay739 merged commit af34189 into main Nov 9, 2026
3 checks passed
@jay739
jay739 deleted the fix/dmg-strict-signature branch November 9, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant