Repository navigation
Tell users when a new release is out - #15
Merged
Merged
Conversation
Ten seconds after launch and then once a day, both apps ask GitHub for the latest release. A newer one appears at the top of the tray or menu bar menu and is announced once, with a balloon on Windows and an alert on macOS; either opens the release page. Nothing is downloaded or installed automatically. "Check for updates" in the menu checks right away, and the daily check can be turned off in Settings. Development builds (0.0.0) skip the automatic check, so the macOS Info.plist now defaults to 0.0.0 instead of 1.0.0, which looked newer than every release. Each platform reports failures as a closed set of error types whose messages say what went wrong and what to do. Version comparison and reply parsing are covered by the same 15 checks on both: windows/test.bat (new, run in CI) and macos/test.sh. Also replaces the em dashes in the files this touches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Both apps now tell you when a new release is out.
/releases/latest).Info.plistnow defaults to 0.0.0 instead of 1.0.0, which looked newer than every release.Why
Users had no way to learn about a new version short of visiting the repository. Notify-only keeps it safe: the builds are ad-hoc signed and not notarized, so installing an update automatically would mean running an unverified download.
How it was tested
windows/test.bat(new, run in this PR's Windows job) andmacos/test.shboth cover the same 15 checks: numeric comparison, prereleases, build metadata, unreadable tags, foreign release pages and malformed replies. Locally: 15/15 on Windows, andtest.sh40/40 on the Mac Mini.