Skip to content

Fix potential file handle leak and minor typo in settings.gradle - #71 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbytecode merged 2 commits into from
Aug 27, 2026
Merged

Fix potential file handle leak and minor typo in settings.gradle - #71 #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885419a
Fix CSVFileWriter opened without closing.
eric-vlaanderen Aug 26, 2026
3156b80
fix typo in settings.gradle
eric-vlaanderen Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RCaller/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
rootprojectt.name = 'RCaller'
rootProject.name = 'RCaller'
14 changes: 11 additions & 3 deletions RCaller/src/main/java/com/github/rcaller/io/CSVFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,28 @@

import com.github.rcaller.datatypes.DataFrame;

import java.io.File;
import java.io.FileWriter;
import java.io.IOException;

public class CSVFileWriter extends FileWriter{

private CSVFileWriter(String filePath) throws IOException {
private CSVFileWriter(final String filePath) throws IOException {
super(filePath);
}

public static CSVFileWriter create(String filePath) throws IOException {
private CSVFileWriter(final File file) throws IOException {
super(file);
}

public static CSVFileWriter create(final String filePath) throws IOException {
return new CSVFileWriter(filePath);
}

public static CSVFileWriter create(final File file) throws IOException {
return new CSVFileWriter(file);
}

public void writeDataFrameToFile(DataFrame dataFrame) throws IOException {
appendArray(dataFrame.getNames());
for (int i = 0; i < dataFrame.getNumberOfRows(); i++) {
Expand All @@ -35,5 +44,4 @@ private void appendArray(Object[] array) throws IOException {
this.flush();
}


}
11 changes: 4 additions & 7 deletions RCaller/src/main/java/com/github/rcaller/util/RCodeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
import com.github.rcaller.scriptengine.LanguageElement;
import org.apache.commons.lang3.ArrayUtils;

import java.io.File;
import java.io.IOException;
import java.io.BufferedReader;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.*;
import java.util.logging.Level;
import java.util.logging.Logger;

Expand Down Expand Up @@ -211,8 +207,9 @@ public static void addRespectToType(StringBuilder rCode, String name, Object o,
public static void addDataFrame(StringBuilder rCode, String name, DataFrame dataFrame) {
try {
File file = File.createTempFile("dataFrame", ".csv");
CSVFileWriter csvFileWriter = CSVFileWriter.create(file.getAbsolutePath());
csvFileWriter.writeDataFrameToFile(dataFrame);
try (CSVFileWriter csvFileWriter = CSVFileWriter.create(file)) {
csvFileWriter.writeDataFrameToFile(dataFrame);
}
rCode.append(name).append(" <- read.csv(\"").append(Globals.getSystemSpecificRPathParameter(file)).append("\")\n");

} catch (IOException e) {
Expand Down
Loading