RTECO-0000 - Fix flaky TestApkAdd_DepChecksums (order-dependent no-op install) - #3711
Merged
naveenku-jfrog merged 1 commit intoSep 15, 2026
Merged
Conversation
…l install TestApkAdd_DepChecksums asserts that at least one dependency has a checksum after `jf apk add curl`, but curl is already installed by TestApkAdd_BasicBuildInfo earlier in the same test binary run. That makes the add a no-op that downloads nothing, so there's no cached .apk archive left to compute checksums from, and AQL enrichment can't help either since these packages are fetched directly from the CDN rather than through Artifactory. Uninstall curl first so the test always exercises a real download.
naveenku-jfrog
added
the
ignore for release
Contributor
agrasth
approved these changes
Sep 15, 2026
naveenku-jfrog
deleted the
RTECO-0000-fix-apk-dep-checksums-test-order
branch
September 15, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestApkAdd_DepChecksumswas failing intermittently depending on test order (seen failing in jfrog-cli-artifactory PR #561 CI) becausecurlis already installed byTestApkAdd_BasicBuildInfoearlier in the same test binary run.jf apk add curlbecomes a no-op: nothing is downloaded into the fresh--cache-dirfor that invocation, so there is no local.apkarchive to compute checksums from. AQL enrichment does not help either, since these test packages are fetched directly from the Alpine CDN, not proxied through Artifactory.name-version.<hash>.apkin build-info-go'sChecksumsFromCache) is correct against a real Alpine 3.18 container; this is purely a test-isolation issue.apk add curlcall, forcing a real download regardless of what earlier tests already installed.Test plan
TestApkAdd_DepChecksumspasses regardless of run ordergo vet ./...andgofmt -l apk_test.goclean (verified locally)Generated with Claude Code