Repository navigation
Handle an Agreed transaction without the options field - #175
Merged
Merged
Conversation
HandleTranAgreed read field 113 as a uint16 without checking it was there, so an Agreed sent without it panicked. The per-transaction recover keeps the connection, but the login stops short: no reply, no NotifyChangeUser to the other users, and no banner. Treat a missing or short options field as no options set, as HandleSetClientUserInfo already does for clients that don't send it.
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandleTranAgreedreads field 113 as auint16without checking it's there, so an Agreed sent without it panics with an index out of range.Since 123d1a3 the per-transaction recover keeps the connection open, but the login stops part-way:
This treats a missing or short options field as no options set, as
HandleSetClientUserInfoalready does.Tests: a "without options field" case in
TestHandleTranAgreed, which panics without the fix.