Skip to content

fix: download folders through symlink roots - #178

Merged
jhalter merged 1 commit into
jhalter:masterfrom
jay23606:fix-symlinked-folder-downloads
Oct 10, 2026
Merged

jhalter merged 1 commit into
jhalter:masterfrom
jay23606:fix-symlinked-folder-downloads

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Summary

  • Follow the target when a folder download starts from a symlinked directory, while keeping the alias path in the paths sent to the client.
  • Close data and resource fork readers after streaming.
  • Add a regression test for a relative symlink target.

Fixes #173

Validation

  • go test ./hotline -run TestDownloadFolderHandler -count=1 passed.
  • go build ./... passed.
  • go vet ./... passed.
  • go test ./... has existing Windows failures in upload-resume and path handling; the same failures occur on clean upstream master.
  • Race tests could not run because this Windows environment has CGO disabled.

@jhalter

jhalter commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution!

@jhalter
jhalter merged commit 0c2d746 into jhalter:master Oct 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory downloads fail silently if the directory is a symlink

2 participants