Repository navigation
Fix Windows import dialog and Xshell session decoding - #250
Merged
Merged
Conversation
zqr10159
marked this pull request as ready for review
October 28, 2026 01:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent handoff
implementationa17dfa2fd61fd94128bbe69dad06fc20363c1988backend/)Fix the Windows source picker whose OK button was outside the form client area, and decode BOM-marked UTF-16 Xshell session files inside
.xtsarchives. UTF-8 files, including those with a BOM, remain supported.Verification
cargo fmt --manifest-path backend/Cargo.toml --checkcargo clippy --locked --manifest-path backend/Cargo.toml --all-targets -- -D warningscargo test --locked --manifest-path backend/Cargo.toml: 1,300 passed;triggers::tests::execute_command_strips_single_trailing_newlinefailed on Windows because its localprintfcommand exited with code 1. This test and its code are unchanged by this PR.The Xshell UTF-16LE, UTF-16BE and UTF-8 BOM regression test passed. A WinForms client-area bounds check passed; live picker behavior at different Windows DPI settings still needs review.
scripts/verify_rdp_vendor_integrity.pyfailed on unchanged vendor trees in this Windows checkout; case-sensitive path ordering reproduces the registered digest for six of seven trees, whilesspistill needs investigation.Security review
Review notes
backend/src/local_fs.rs,backend/src/connection_import.rs.