Repository navigation
Install plugins over HTTPS, not SSH - #6
Merged
Merged
Conversation
A git-subdir url in the short owner/repo form clones over SSH, so installing crew or board fails with "Permission denied (publickey)" for any user with no GitHub SSH key. Use the full HTTPS clone URL, and make the validator require it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KCgMeGSUWjfoweh4qiasse
There was a problem hiding this comment.
🟢 Approved
No active review issues block the change to HTTPS-based plugin installation.
No open issues 🎉
What changed in this PR
This PR switches plugin installation to HTTPS so users without GitHub SSH keys can install crew and board.
Changes:
- Replaces both plugins’ short repository references with full HTTPS clone URLs.
- Updates CI to require HTTPS URLs for
git-subdirsources and extract repository paths for manifest validation. - Documents the HTTPS requirement for maintainers.
| File | Description |
|---|---|
| README.md | Explains why plugin sources must use full HTTPS clone URLs. |
| .github/workflows/validate.yml | Checks HTTPS URL format and derives manifest-fetch URLs. |
| .claude-plugin/marketplace.json | Changes crew and board sources to HTTPS clone URLs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A
git-subdirurlin the shortowner/repoform makes Claude Code clone over SSH (git@github.com:owner/repo.git). Any user with no GitHub SSH key cannot installcreworboard:Changes
marketplace.json: thecrewandboardentries use the full HTTPS clone URL. Both repos are public, so no login is needed.validate.yml: agit-subdirurlmust behttps://github.com/<owner>/<repo>.git. The step takesowner/repofrom it to fetchplugin.json.README.md: Maintaining states the rule.Checks
I ran the validator step locally:
ok: crew,ok: board, exit 0crewset back tojohantor/crew:FAIL: crew: git-subdir url must be https://github.com/<owner>/<repo>.git, exit 1Generated by Claude Code