test: phase 2 coverage for ConfigService and HttpService - #25
Merged
Conversation
Add a config-directory override to ConfigService and an injectable client factory to HttpService so config round-trip/merge/resolvers, the ResolvePullRequestUrl config path, and the work-item/pull-request HTTP paths can be tested without the real store or network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2: ConfigService and HttpService coverage
Follows Phase 1 (#22). Adds two small production seams and the tests they unlock, mirroring the timetracker-cli phase 2. No runtime behavior changes.
Production seams
ConfigServicehonors aDEVOPS_CONFIG_DIRoverride inGetConfigDirectory(). Unset for normal users, so the runtime config path is unchanged; tests point it at a throwaway directory.HttpService.ClientFactory(Func<RestClientOptions, RestClient>, defaults tonew RestClient(options)). The twoCreateClientAsyncoverloads now build through it; tests inject a stub message handler on the options. No public API change and no changes to call sites.Tests (15 new, 64 total)
ConfigServiceTests— Save/Load round-trip (PAT decrypts, auth mode inferred), non-destructive merge,ResolveProject(explicit/default/throws),ResolveUserId(present/throws),DeleteConfig, all against a temp dir.ResolvePullRequestUrlConfigTests— the build-from-config fallback (org URL + project/repo).HttpServiceTests—GetWorkItem,GetPullRequest,CreatePullRequest(asserts branch normalization + reviewers in the body),AddPullRequestComment— success and failure paths via a stub handler.Pack of the tool is unaffected.
Closes #24