refactor(config): make config updates non-destructive - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Configuration updates are now non-destructive. Previously
SaveConfigrebuilt the whole config from the provided options, so any partial update would wipe the fields that were not passed (for example, changing the URL would drop the stored token). It now merges into the existing configuration, matching the sibling devops-cli.ConfigService
SaveConfigmerges: only values actually supplied overwrite the stored ones (opts.X ?? existing.X).WriteConfig(Config)that owns token encryption, making the pair symmetric:LoadConfigdecrypts,WriteConfigre-encrypts (guarded against an empty token).SetTableBorderworkaround that existed only because the previous save was destructive.GetTableBorderstays, since table rendering reads the border without needing to decrypt the token.ConfigValidator
Config command
--urlor--tokenare supplied. Other updates (such as--border) merge locally with no network call.Verification
Validated locally end to end: partial updates preserve credentials, a follow-up authenticated request still succeeds (confirming the token survives the encrypt/decrypt round trip), token rotation keeps the URL, and the error paths behave (missing options, invalid border, non-HTTPS URL).