Repository navigation
test: Cover the Ubuntu shell contract in Docker E2E - #17
Merged
Merged
Conversation
ssh2 emits error after client.end() returns. Dropping the listener made that late error an uncaught exception.
The local runner checks Node 24 and a running Docker daemon. The suite exercises auth, timeouts, abort, pager, and disconnect against sshd.
|
Warning Review limit reachedNext included review available in 49 seconds. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the Docker Ubuntu E2E suite so the public shell contract is exercised against a real sshd, and keep a late
ssh2errorfrom becoming an uncaught exception afterclient.end().npm run test:e2eis the local runner and the CIe2ejob. It now refuses to start unless Node is>=24.21.0 <25and the Docker daemon is running.Scope
e2e/client.e2e.test.ts,tools/e2e.sh,vitest.e2e.config.tssrc/session.tsandtests/session-races.test.tsfor the post-close error listenerREADME.md,docs/usage.md,CHANGELOG.mdOut of scope: resync failure against a healthy bash (still a unit test), numeric option bounds, and publishing a release.
Acceptance criteria / DoD
npm run test:e2eruns locally against Ubuntu 24.04 sshdTERMend()does not escape as an uncaught exceptionTest plan
npm run test:coverage(166 unit tests, per-file floor held)npm run test:e2eon Node 24.21.0 (28 Docker Ubuntu tests passed)ciande2eon this PR