Skip to content

test: Reach 100% coverage with no exclusions - #33

Merged
soulevilx merged 1 commit into
developfrom
test/JOODT-23-ssh-client-100-coverage
Oct 17, 2026
Merged

soulevilx merged 1 commit into
developfrom
test/JOODT-23-ssh-client-100-coverage

Conversation

@soulevilx

Copy link
Copy Markdown
Contributor

Purpose: owner requirement of 100% statements, branches, functions and lines, overall and per file, with no exclusions or ignore comments. Jira: JOODT-23.
Scope: new tests; thresholds and the per-file floor raised to 100; removed coverage exclude. Production changes (behavior-neutral for valid input): charAt instead of indexed access with fallback, endPromise made non-optional, three exhaustive-switch defaults now throw TypeError for invalid runtime discriminants.
Checks: clean npm ci; npm run ci exit 0 (20 files, 229 tests, 100% on all four metrics, 0 vulnerabilities). Independently re-run by QA.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f68c1dfa-536a-4046-805f-93421fa5858f
📥 Commits

Reviewing files that changed from the base of the PR and between 2bc2006 and bceaa0f.

📒 Files selected for processing: 15
  • src/attempt-plan.ts
  • src/output-accumulator.ts
  • src/session.ts
  • tests/attempt-plan.test.ts
  • tests/client-barrier.test.ts
  • tests/client.test.ts
  • tests/coverage-floor.test.ts
  • tests/index.test.ts
  • tests/output-accumulator.test.ts
  • tests/session-internals.test.ts
  • tests/session-races.test.ts
  • tests/shell-io-extras.test.ts
  • tests/shell-io-internals.test.ts
  • tools/check-per-file-coverage.mjs
  • vitest.config.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soulevilx
soulevilx merged commit 153cc1e into develop Oct 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant