execute op_block nodes - #30
Open
christianp wants to merge 1 commit into
Open
Conversation
The commit 8bbcc2a added an `op_block` node, for blocks of code inside curly braces. A case was added to the `compile` function, but no corresponding case was added to the `execute` function, so blocks of code just aren't executed any more. So code like this: ``` if(true) { point(0,0); } ``` would produce nothing, instead of a point at the origin. I think that just executing the single child node is all that needs to happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 8bbcc2a added an
op_blocknode, for blocks of code inside curly braces. A case was added to thecompilefunction, but no corresponding case was added to theexecutefunction, so blocks of code just aren't executed any more.So code like this:
would produce nothing, instead of a point at the origin.
I think that just executing the single child node is all that needs to happen.