Skip to content

Fix TODO copying sets that are not isbitstype #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Oct 28, 2026
+49 −18
Merged

Fix TODO copying sets that are not isbitstype #3120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions src/sets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ struct GreaterThan{T<:Real} <: AbstractScalarSet
lower::T
end

Base.copy(set::GreaterThan) = GreaterThan(copy(set.lower))

Base.:(==)(a::GreaterThan{T}, b::GreaterThan{T}) where {T} = a.lower == b.lower

"""
Expand All @@ -185,6 +187,8 @@ struct LessThan{T<:Real} <: AbstractScalarSet
upper::T
end

Base.copy(set::LessThan) = LessThan(copy(set.upper))

Base.:(==)(a::LessThan{T}, b::LessThan{T}) where {T} = a.upper == b.upper

"""
Expand All @@ -208,6 +212,8 @@ struct EqualTo{T<:Number} <: AbstractScalarSet
value::T
end

Base.copy(set::EqualTo) = EqualTo(copy(set.value))

Base.:(==)(a::EqualTo{T}, b::EqualTo{T}) where {T} = a.value == b.value

"""
Expand Down Expand Up @@ -243,6 +249,8 @@ struct Parameter{T<:Number} <: AbstractScalarSet
value::T
end

Base.copy(set::Parameter) = Parameter(copy(set.value))

Base.:(==)(a::Parameter{T}, b::Parameter{T}) where {T} = a.value == b.value

"""
Expand Down Expand Up @@ -274,6 +282,8 @@ function Interval(lower::Real, upper::Real)
return Interval(promote(lower, upper)...)
end

Base.copy(set::Interval) = Interval(copy(set.lower), copy(set.upper))

function Base.:(==)(a::Interval{T}, b::Interval{T}) where {T}
return a.lower == b.lower && a.upper == b.upper
end
Expand Down Expand Up @@ -374,6 +384,10 @@ function Semicontinuous(lower::Real, upper::Real)
return Semicontinuous(promote(lower, upper)...)
end

function Base.copy(set::Semicontinuous)
return Semicontinuous(copy(set.lower), copy(set.upper))
end

function Base.:(==)(a::Semicontinuous{T}, b::Semicontinuous{T}) where {T}
return a.lower == b.lower && a.upper == b.upper
end
Expand Down Expand Up @@ -408,6 +422,8 @@ function Semiinteger(lower::Real, upper::Real)
return Semiinteger(promote(lower, upper)...)
end

Base.copy(set::Semiinteger) = Semiinteger(copy(set.lower), copy(set.upper))

function Base.:(==)(a::Semiinteger{T}, b::Semiinteger{T}) where {T}
return a.lower == b.lower && a.upper == b.upper
end
Expand Down Expand Up @@ -921,6 +937,8 @@ dual_set_type(::Type{PowerCone{T}}) where {T<:Real} = DualPowerCone{T}

dimension(::PowerCone) = 3

Base.copy(set::PowerCone) = PowerCone(copy(set.exponent))

function Base.:(==)(x::PowerCone{T}, y::PowerCone{T}) where {T}
return x.exponent == y.exponent
end
Expand Down Expand Up @@ -951,6 +969,8 @@ dual_set_type(::Type{DualPowerCone{T}}) where {T<:Real} = PowerCone{T}

dimension(::DualPowerCone) = 3

Base.copy(set::DualPowerCone) = DualPowerCone(copy(set.exponent))

function Base.:(==)(x::DualPowerCone{T}, y::DualPowerCone{T}) where {T}
return x.exponent == y.exponent
end
Expand Down Expand Up @@ -2946,24 +2966,6 @@ function Base.show(io::IO, s::VectorNonlinearOracle{T}) where {T}
return
end

# TODO(odow): these are not necessarily isbits. They may not be safe to return
# without copying if the number is BigFloat, for example.
function Base.copy(
set::Union{
GreaterThan,
LessThan,
EqualTo,
Parameter,
Interval,
Semicontinuous,
Semiinteger,
PowerCone,
DualPowerCone,
},
)
return set
end

"""
supports_dimension_update(S::Type{<:MOI.AbstractVectorSet})

Expand Down
29 changes: 29 additions & 0 deletions test/General/test_sets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,35 @@ function test_VectorNonlinearOracle()
return
end

struct MyNum <: Real
x::Base.RefValue{Float64}
end

Base.copy(x::MyNum) = MyNum(Ref(x.x[]))

Base.:(==)(x::MyNum, y::MyNum) = x.x[] == y.x[]

function test_set_copy_not_isbitstype()
# copy(::BigInt) is a shallow copy by explicit design in Julia.
set = MOI.GreaterThan(big"1")
@test copy(set) === set
for set in Any[
MOI.GreaterThan(MyNum(Ref(1.0))),
MOI.LessThan(MyNum(Ref(1.0))),
MOI.EqualTo(MyNum(Ref(1.0))),
MOI.Interval(MyNum(Ref(1.0)), MyNum(Ref(3.0))),
MOI.Parameter(MyNum(Ref(1.0))),
MOI.Semicontinuous(MyNum(Ref(1.0)), MyNum(Ref(3.0))),
MOI.Semiinteger(MyNum(Ref(1.0)), MyNum(Ref(3.0))),
MOI.PowerCone(MyNum(Ref(1.0))),
MOI.DualPowerCone(MyNum(Ref(1.0))),
]
@test copy(set) == set
@test copy(set) !== set
end
return
end

end # module

TestSets.runtests()
Loading