Skip to content

Workaround slow inference for deletion #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blegat wants to merge 1 commit into from
Closed

Workaround slow inference for deletion #3125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Utilities/struct_of_constraints.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,16 @@ function final_touch(model::StructOfConstraints, index_map)
return
end

# Avoid compiling the recursive deletion passes for constraint containers that
# are not present in the model.
function _throw_if_cannot_delete(model::StructOfConstraints, vis, fast_in_vis)
broadcastcall(model) do constrs
if constrs !== nothing
_throw_if_cannot_delete(constrs, vis, fast_in_vis)
_throw_if_cannot_delete(
Base.inferencebarrier(constrs),
vis,
fast_in_vis,
)
end
return
end
Expand All @@ -49,7 +55,7 @@ function _deleted_constraints(
)
broadcastcall(model) do constrs
if constrs !== nothing
_deleted_constraints(callback, constrs, vi)
_deleted_constraints(callback, Base.inferencebarrier(constrs), vi)
end
return
end
Expand Down
Loading