Repository navigation
Conversation
Cover both variable and constraint support dispatches with supported and unsupported sets. Verify that bridgeable rejects unsupported variable and constraint bridges with AssertionError, and include the standalone regression tests in runtests.jl. Apply JuliaFormatter 2 formatting to the branch. Validation: all 7 bridge tests and 86 variable tests pass (4 existing broken tests). Temporary @show line tracing and Julia coverage confirm both previously missed variable-support lines execute. JuliaFormatter 2.14.7 and git diff --check pass.
CI tests the merge with main but uploads coverage against the PR head. Source lines had shifted between these trees, causing Codecov to mark added comments as uncovered and report 82.35% patch coverage. Merge main so coverage line numbers match the PR source and the diff contains only the intended bridge-support changes. Validation: the merged tree matches the merge tree already tested successfully by CI. All 347 checks in test/bridgeable.jl and test/constraint.jl pass locally. Coverage confirms hits on all six executable source lines added by the PR. JuliaFormatter 2.14.7 and git diff --check pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I always gets confused by this otherwise.