Repository navigation
Update to MP v0.6 - #163
Merged
Merged
Conversation
Use the new DynamicPolynomials aliases and explicit full-basis expansion in algebraic-set bridges and relaxation multipliers. Define JuMP and MOI coefficient arithmetic explicitly, including mixed types and finite-basis inputs, and reuse the algebra-element value path. Keep SAGE decompositions as wrappers and fold nonlinear operands without constructing abstractly typed polynomial arrays. Domain promotion uses the SemialgebraicSets prerequisite cbd4e07 on bl/sa_refactor. Validated coefficient, variable, constraint, mock bridge, SAGE, and QCQP test files against the local refactor branches. Temporary line probes verified the new dispatch paths; all were removed. JuliaFormatter 2.x leaves no diff.
Select the current polynomial refactor branches and MutableArithmetics main for dependencies in package and auxiliary environments. Reference this package by a relative path in its own environments. Validated all project files with Julia Pkg and resolved an isolated copy of the SumOfSquares test environment with the full local refactor chain and MutableArithmetics main (1.9.0). Formatting matches the CI workflow.
Replace MutableArithmetics source overrides with a 1.9 compatibility bound in the package and auxiliary environments. Validated all project files and compatibility bounds with Julia Pkg. The full local refactor chain resolves against registered MutableArithmetics 1.9.0, and the CI formatter checks pass.
Remove the duplicated JuMP and MOI operators for SA terms and algebra elements. Retain only bare-monomial adapters and their product promotion, so MA rewrites can also multiply MOI variable indices by monomials. Require SA 0.4 and validate function and variable tests with DP and TP, including rewritten scalar products and finite-basis promotion.
Remove the duplicate JuMP and MOI monomial operators and promotion methods. Use the SA scalar-extension branch and cover subtraction rewrites when polynomial coefficient types widen. The focused functions and variable tests pass with both DP and TP: 568 passed and four existing broken tests. Repository formatting is clean.
Remove value, display, and index-free metadata methods now provided by SA, MP, and MM extensions. Keep build_constraint overloads and mark their type piracy for a separate review. Check parent-preserving term evaluation and constraint display.
blegat
force-pushed
the
bl/sa_refactor
branch
from
November 2, 2026 12:12
ed367bd to
c30ed86
Compare
|
Do you mind making a new release for these changes? |
Member
Author
|
I'm planning to make a few breaking changes as part of this release, do you need a backport release ? |
|
No, I just saw that this package is holding back the MP version. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.