fix: add three-tier fallback health state (healthy/partial/degraded) for Issue #682#685
Closed
jununfly wants to merge 1 commit into
Closed
fix: add three-tier fallback health state (healthy/partial/degraded) for Issue #682#685jununfly wants to merge 1 commit into
jununfly wants to merge 1 commit into
Conversation
…for Issue #682 Distinguish expected fallbacks (non-Rust-owned languages like YAML) from unexpected gaps (Rust-owned parse/extraction failures, missing files). State logic: - healthy: zero fallbacks, zero gaps - partial: only language-level-typescript-fallback (expected, non-Rust-owned) - degraded: any rust-owned-* gap or language-level-fallback-missing-file Changes: - RustHybridFallbackState type: add 'partial' - rustHybridFallbackStateFor(): three-tier logic - formatRustHybridFallbackHealthLines(): partial output with info line + lang breakdown - formatRustHybridFallbackDoctorHint(): partial returns hint without doctor command - clack.log: conditional info (partial) / warn (degraded) - statusFallbackDiagnostics: returns data for partial (empty doctorCommand) - classifyGraphHealth: partial treated as healthy graph health - diagnostics/index.ts: fallbackState override handles partial - 11 new TDD tests + 7 existing tests updated Closes #682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Distinguish expected fallbacks (non-Rust-owned languages like YAML) from unexpected gaps (Rust-owned parse/extraction failures, missing files).
Problem
Issue #682 reported that indexing a TypeScript-heavy project (ZAgenticLoop) showed
Fallback health: degradedfor 58 YAML files — but these are expected fallbacks, not problems. Thedegradedlabel caused unnecessary user concern.Solution
Three-tier fallback health state:
healthypartiallanguage-level-typescript-fallback(non-Rust-owned languages, successfully indexed)degradedrust-owned-*gap orlanguage-level-fallback-missing-fileKey changes
RustHybridFallbackStatetype: add'partial'rustHybridFallbackStateFor(): three-tier logic checking taxonomy keysformatRustHybridFallbackHealthLines(): partial output with info line + language breakdown (no "need review")formatRustHybridFallbackDoctorHint(): partial returns hint without "Run diagnostic bundle"clack.log: conditionalinfo(partial) /warn(degraded)statusFallbackDiagnostics: returns data for partial (empty doctorCommand)classifyGraphHealth: partial treated as healthy graph healthdiagnostics/index.ts: fallbackState override handles partialBefore (Issue #682 scenario)
After
Test plan
issue-682-partial-fallback-state.test.tstsc --noEmitzero errorsCloses #682