feat: meta marker for stoml - #1157
yuvrajjsingh0 wants to merge 2 commits into
Conversation
Changed Files
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughTOML configuration files now support optional SuperTOML type and version metadata. Parsing validates provided metadata and warns when it assumes version 1. Serialization emits metadata, and tests and documentation cover the format. ChangesTOML metadata
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The metadata example is valid, and no actionable merge-blocking issue remains after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to No introduced security issue was identified. Existing files without metadata remain readable, but exports have a new shape whose compatibility with every downstream reader is not established. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 40.91% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the TOML page, Comment |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address repeated/unobservable legacy-file warnings and correct the documented metadata example.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds versioned [meta] marker support for SuperTOML files with validation, serialization, backward compatibility, documentation, and tests.
Changes:
- Validates metadata type and version.
- Emits metadata during serialization.
- Warns for unmarked files.
- Adds documentation and test coverage.
| File | Description |
|---|---|
docs/docs/superposition-config-file/format-specification.md |
Documents metadata syntax and validation. |
crates/superposition_core/src/format/toml.rs |
Implements metadata parsing, validation, warnings, and serialization. |
crates/superposition_core/src/format/tests/toml.rs |
Tests metadata behavior and warnings. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Problem
Meta marker support for stoml to effectively ship new versions and helps validating a file is stoml even if the extension is
.tomlSolution
Add a meta marker to toml where the default is pinned to version 1, with a warning asking people to pin their version in the toml file itself if meta marker is not present in toml
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
N/A
Post-deployment activity
N/A
API changes
N/A
Possible Issues in the future
Describe any possible issues that could occur because of this change
Summary by CodeRabbit