Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 767 files, which is 667 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (767)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDK consumers and provider users had no way to identify their application to the Superposition server via the standard
user-agentHTTP header.Solution
smithy/models/main.smithy): added an **optional**user_agentmember bound to theuser-agentheader inWorkspaceMixinandOrganisationMixin, so it propagates to all ~80 operations.metadata suppressionsfor theHttpHeaderTraitDANGER event (Smithy discourages bindinguser-agent, suppressed for our namespace).apply ...$user_agent @notPropertystatements for the 62 resource-bound operation inputs (resource operations require non-identifier/non-property members to be marked@notProperty; the trait can't be applied on mixin members directly).make smithy-updates): Rust, TypeScript, Python, Java, Haskell + OpenAPI spec/docs. All exposeuser_agentas optional.user_agent: Option<String>+with_user_agent()onSuperpositionOptions/SuperpositionProviderOptions(backwards-compatible, constructors unchanged)user_agent?: stringonSuperpositionOptionsuser_agent: Optional[str] = Noneon options dataclasses@Nullable userAgentonSuperpositionProviderOptionsuserAgent :: Maybe TextonSuperpositionProviderOptionsWhen unset, no
user-agentheader is sent by the modeled binding (SDK runtimes may still send their own default).Environment variable changes
None
Pre-deployment activity
None
Post-deployment activity
None
API changes
user-agentrequest header (OpenAPI updated)Possible Issues in the future
apply <OpInput>$user_agent @notPropertyline inmain.smithy;smithy buildfails with a clearResourceOperationInputOutputerror if forgotten.