Repository navigation
feat: requirement checks, windows support, diagnostics log - #8
Merged
Merged
Conversation
- main menu shows ffmpeg/ffprobe/python and the optional modules, and asks y/n to install whatever required binary is missing, using the detected package manager: winget, chocolatey or scoop on windows, homebrew on macos, apt-get/dnf/pacman/zypper/apk on linux - windows runtime: msvcrt key decoding, no-op raw session, utf-8 and vt console setup, registry path refresh after an install, os.startfile, Scripts/python.exe venv interpreter, subprocess re-exec instead of execv - effex.cmd launcher and install.ps1 shim installer for windows; README gains a requirements section with per-os install commands - diagnostics.py logs every warning, error, ffmpeg stderr and traceback to one bounded per-user file; --logs prints it, --report writes a single attachable file with the environment header - tests: platform_support (42 checks), logging_regression (44), install_prompt rewritten (29); ci gains a windows job
…he first broken suite - harness.run prefixes sys.executable for .py targets on windows (winerror 193) - the log header check only demands a probed version when ffmpeg exists - windows ci steps exit on $LASTEXITCODE, so a failing suite cannot pass silently
…lyphs windows pipes default to cp1252, so every piped run died on the first tick in ok()/err(). the stream is switched to utf-8 only when the current encoding cannot encode the glyph, which also covers ascii C locales on unix.
mpeg4 keyframe placement shifts with the encoder build, so the windows runner measured 4.82 where linux measures higher. anything over 2 is beyond noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
the optional numpy/opencv/PyAV modules, with one row per item when the
terminal is tall enough. missing required binaries trigger
install ffmpeg + ffprobe now? [Y/n]before the menu opens, and therequirementsrow (orc) asks again after a decline.windows (no sudo, agreements pre-accepted), homebrew on macos, and
apt-get/dnf/pacman/zypper/apk with sudo on linux. one command per package, so
ffmpeg + ffprobe install in one go.
--checkexits 1 when anything requiredis missing and
--check --jsonnow reports platform, installer, hint and oneobject per requirement.
code pairs, a no-op raw session, utf-8 + virtual-terminal console setup,
registry path refresh after an install, os.startfile for folders, the
Scripts\python.exevenv layout and a subprocess re-exec instead of execv.new
effex.cmdlauncher andinstall.ps1shim installer.diagnostics.pykeeps one bounded per-user log with every warning, error,ffmpeg stderr and traceback.
--logsprints the path and tail,--report [PATH]writes a single file with the environment header for an issue, and afailed render shows the log path with an
lkey. a clean run writes nothing.this branch also carries the earlier
Finally fixed datamoshingcommit.verified
python3 tests/run_tests.pygreen (14 suites, including the newplatformand
loggingsuites)layout 177/177
and a corrupt-clip render whose log keeps ffmpeg's
moov atom not found--check --jsonand--liston windows-latest