Repository navigation
Conversation
Signed-off-by: Salah <nh.salah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checkpoint whose snapshot creation fails cannot be deleted: the store only admits READY and DELETING records, so the owner receives NotFound and the failed checkpoint keeps its runtime revision pinned.
Allow FAILED checkpoints to enter the existing deletion workflow. When Substrate confirms the tag is absent, remove the checkpoint record without another delete-by-name request. If a tag exists, require a retained UID and matching identity before deleting it. Backend failures preserve the record for retry, and ownership and fork-reference checks remain in place.
Refs #2746. This addresses failed-checkpoint deletion only; automatic recovery of abandoned CREATING/DELETING operations remains follow-up work.
Validation
begin delete Session checkpoint: record not foundand passes with the fix.go test -race ./core/internal/service/checkpoint -count=1passes.go test -race ./core/internal/database -skip '^TestSessionExpiration' -count=1passes, including inline SQL preparation and runtime-revision retention coverage.go test -race ./core/pkg/migrations -count=1passes.git diff --checkpass.The unfiltered database suite has failures in five session-expiration tests. The same failures were reproduced with the production code restored to the base main revision. Full repository lint was blocked during tool setup by local Go checksum-cache permissions; live Substrate E2E validation has not been run.
Tests were run against base revision f2d7cc4. The change also documents failed-checkpoint cleanup semantics.
AI assistance: Codex helped implement and validate this contribution.