Repository navigation
Add PHP 8.5 to the matrix - #4
Merged
Merged
Conversation
kanopi/firewall has supported 8.1 to 8.5 since 2.31.0, and the plugin
was testing a subset of that. Unit runs on 8.5 now, and so does a full
integration job.
The integration row is paired with the existing nightly one rather than
replacing it. The two differ only in PHP, so a failure on 8.5 that passes
on 8.4 says "PHP 8.5" and not "WordPress trunk moved" -- and integration
is where every defect this plugin has shipped so far has lived, which is
why the newest PHP gets a run of it rather than unit coverage alone.
Verified before adding, in the images CI uses:
unit cimg/php:8.5 55 tests, junit written green
integration cimg/php:8.5 122 + 6 e2e + 25 wp-cli,
against WordPress nightly green
Two deprecations show up on 8.5 and neither is ours: `react/promise` and
`php-cli-tools`, both inside WP-CLI's own phar. Nothing from the plugin,
and the unit suite -- which unlike the integration suite runs with
failOnWarning -- is clean.
`static` stays on 8.1 and `package` on 8.3. Neither is about breadth:
static runs on the floor because that is where check-platform-reqs means
something, and package runs on 8.3 because that is PHP-Scoper's floor.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP 8.5 change missed the train. #3 was merged into
cli-command-coverageat 05:01 and I pushed this commit to thecirclecibranch afterwards, so the squash-merge of #2 carried the CircleCI migration tomainwithout it.maintoday runs nine jobs and tops out at PHP 8.4.This is that commit, cherry-picked onto
main. Nothing about it changed.kanopi/firewallhas supported 8.1 through 8.5 since 2.31.0 and the plugin was testing a subset of it. 8.5 joins the unit matrix and gets a full integration job paired with the existing nightly row rather than replacing it — the two differ only in PHP, so a failure on 8.5 that passes on 8.4 says "PHP 8.5" and not "WordPress trunk moved".Verified in the images CI uses, before it was written:
unitcimg/php:8.5integrationcimg/php:8.5Two deprecations surface on 8.5 and neither is ours:
react/promiseandphp-cli-tools, both inside WP-CLI's own phar. Nothing from the plugin, and the unit suite — which unlike the integration suite runs withfailOnWarning— is clean.staticstays on 8.1 andpackageon 8.3. Neither is about breadth: static runs on the floor because that is wherecheck-platform-reqsmeans something, and package runs on 8.3 because that is PHP-Scoper's floor.Required status checks gain two names:
unit-php-8.5andintegration-wpnightly-php8.5.