Repository navigation
refactor(taskfile): own the report-engine no-op before lib drops it - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib v2.6.0 removes the toolbox's
report-engineno-op (consistency review C6). dropbox includes the toolbox and no engine, so itsreportwould then call a task that does not exist. This defines dropbox's own no-op and excludes the toolbox's, so the run works on v2.5.0 and on v2.6.0.This must merge before lib v2.6.0 is tagged.
Test plan
task check: render matches render.txt (unchanged)task test: 160 passedtask lint: clean