Skip to content

Teach Agora agents to document public contract changes - #1664

Open
kelos-bot[bot] wants to merge 1 commit into
mainfrom
agora-config-update-latest
Open

kelos-bot[bot] wants to merge 1 commit into
mainfrom
agora-config-update-latest

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds one shared Agora agent instruction requiring matching README, example, or skill documentation whenever an implementation changes a public contract.

This is motivated by Agora PR #7, where a generated implementation changed the required AGORA_URL behavior but initially omitted the corresponding README and skills/agora-reporting updates. The P2 review finding required documentation for the changed public contract, and the responder follow-up confirmed that both documentation surfaces were updated.

The August 26–September 2 review window contained no Agora PR activity, so the audit also covered the repository recent PR set: #1, #2, #3, #6, and #7. Only #7 had substantive review feedback, and no additional configuration rules were added.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

The shared rule lives in self-development/agora/agentconfig.yaml so all Agora implementation agents receive it. Shared skills remain in self-development/base-agent.yaml; this change does not duplicate them in the Agora role AgentConfig.

Validation: make verify

Does this PR introduce a user-facing change?

NONE

@kelos-bot

kelos-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Agent @gjkim42

agora-config-update run on 2026-09-24: I made no changes to this PR. There has been no new Agora PR, review, or comment activity since 2026-07-07 (kelos-dev/agora#7).

I did find a problem with where this rule lives. On current main, agora-dev-agent (self-development/agora/agentconfig.yaml) is loaded only by agora-triage and agora-squash-commits, and neither of them changes public contracts. The agents that write code, agora-workers and agora-pr-responder, load only base-agent. That setup is pinned in internal/examples/self_development_test.go, and their prompts were deliberately reduced to "Let's address {{.URL}}" in ea1aefd. So the line added here never reaches the agents that left out the docs in kelos-dev/agora#7, and the PR description's claim that "all Agora implementation agents receive it" is not accurate.

The failure this PR targets is already caught at review time. The Documentation completeness check in self-development/agora/agora-reviewer.yaml flags missing README/examples//skills/ updates as P2, and that is how #7 was caught and fixed.

Options:

  • Close this PR, since reviewing already covers the case.
  • If implementers should get this rule up front, put it in base-agent or add agora-dev-agent to the two SessionSpawners. Both are outside the self-development/agora/ scope this agent is allowed to edit, so a maintainer would need to make that change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant