Conversation
github-actions
Bot
added
kind/bug
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
scottt732
had a problem deploying
to
ok-to-test
September 11, 2026 18:58 — with 
GitHub Actions
Error
GitHub Actions
Error
Codex app-server publishes notifications for native subagent threads as well as the Session's root thread. Kelos applied every notification to the root interaction, so a child error or completion could terminate the Session request while the root agent kept working, and child output or usage could be attributed to the parent. Filter thread-scoped notifications to the provider's root thread before changing interaction state or emitting events. Notifications without a thread scope, including account-wide rate limits, are preserved, and initial thread-ID publication is synchronized with the notification reader so the handler never compares against a stale ID. The regression test feeds child startup, text, error and completion notifications and verifies the parent still emits output and completes normally. Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
scottt732
force-pushed
the
fix/codex-child-notifications
branch
from
September 17, 2026 22:18
30a4887 to
baf75a1
Compare
scottt732
requested a deployment
to
ok-to-test
September 17, 2026 22:18 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Codex app-server publishes notifications for native subagent threads as well as the Session's root thread. Kelos currently applies every notification to the root interaction: a child error or completion can terminate the Session request while the root agent continues working, and child output or usage can be attributed to the parent.
Filter thread-scoped notifications to the provider's root thread before changing interaction state or emitting events. Preserve notifications without thread scope, including account-wide rate limits. Synchronize initial thread-ID publication with the notification reader.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Reproduced with a persistent Codex Session spawning native analysts: one child failed while the root kept working, but the Session client received failure and disconnected. The regression test feeds child startup, text, error and completion notifications and then verifies the parent still emits output and completes normally.
Validation:
go test ./internal/sessionruntime -run TestCodex -count=1 -race -timeout=90spassed. The new regression failed before the fix. Broader coverage is delegated to CI.Does this PR introduce a user-facing change?
Summary by cubic
Filters Codex Session notifications by thread so child subagent events no longer affect the parent session. Previously, a child error or completion could prematurely finish the parent turn or be attributed as parent output.
Written for commit baf75a1. Summary will update on new commits.