Add telemetry support to browser-pools CLI commands#205
Merged
Conversation
Bring the CLI to parity with the API/SDK telemetry surface for browser pools: --telemetry on browser-pools create/update/acquire, display the active config in browser-pools get, and forward --telemetry as an acquire override on browsers create --pool-id/--pool-name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Replace five near-identical all/off/categories switches (browser create/update + pool create/update/acquire) with a single resolveTelemetryFlag resolver and thin per-endpoint adapters, so the --telemetry flag grammar has one source of truth. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sayan-
marked this pull request as ready for review
July 21, 2026 16:05
Sayan-
requested review from
archandatta and
tnsardesai
and removed request for
archandatta
July 21, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the CLI to parity with the API/SDK browser-pool telemetry surface (shipped in kernel-go-sdk v0.79.0).
What changed
kernel browser-pools create --telemetry=all|off|<categories>sets the telemetry applied to browsers warmed into the pool.kernel browser-pools update --telemetry=...updates pool telemetry. Only applies to browsers warmed after the update.kernel browser-pools acquire --telemetry=...sets a per-lease override, merged onto the pool config.kernel browser-pools getnow shows the pool's active telemetry in the details table.kernel browsers create --pool-id/--pool-name --telemetry=...now accepts--telemetryas a per-lease flag and forwards it as an acquire override. Previously it was treated as a conflicting config flag and dropped.Pool and browser
--telemetryshare the same parsing (all/off/ comma-separated categories), so they behave identically.Testing
Built
bin/kerneloff this branch and exercised each new path end-to-end:browser-pools create --telemetry=console,networkbrowser-pools getbrowser-pools update --telemetry=all/=offgetbrowser-pools acquire --telemetry=pagebrowsers create --pool-name … --telemetry=console--telemetryon create/update/acquireNote
Low Risk
CLI-only feature parity with the SDK; validation runs before API calls and behavior mirrors existing browser telemetry flags.
Overview
Adds
--telemetryto browser pool create, update, and acquire, aligned with single-browser telemetry (all/off/ category lists) via a sharedresolveTelemetryFlaghelper and SDK v0.79.0.Pool create/update send telemetry on warmed browsers; update only affects browsers warmed after the change. Acquire (and
browsers create --pool-id|--pool-name) can pass a per-lease override merged onto the pool config—--telemetryis now allowed on the pool lease path instead of being treated as a conflicting flag.browser-pools getshows a Telemetry row; create/update printprintTelemetrySummarywhen the flag is set.README documents the new flags. Tests cover pool telemetry params, acquire forwarding, and invalid categories.
Reviewed by Cursor Bugbot for commit 0e54cb3. Bugbot is set up for automated code reviews on this repo. Configure here.