chore(windows): convert keyman engine for windows insthelper to C++ - #16296
Draft
sze2st wants to merge 7 commits into
Draft
chore(windows): convert keyman engine for windows insthelper to C++#16296sze2st wants to merge 7 commits into
sze2st wants to merge 7 commits into
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions
Results Template |
Contributor
Author
User Testing
Details need to be specified
Details need to be specified |
…for-windows-insthelper
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
mcdurdin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #8700
Fix replaces folder
windows/src/engine/insthelper(containing Delphi sources) withwindows/src/engine/inst-cpp(containing C++ sources). Hence it replacesinsthelper.dllwithinst-cpp.dllincluding required changes inwindows/src/engine/inst/keymanengine.wxsBuild-bot: release:windows