Add CI with cross-platform build matrix - #17
Merged
Conversation
Adds a GitHub Actions workflow that installs, typechecks, tests, and
builds the SEA binary on ubuntu-latest/macos-latest/windows-latest on
every push to main and every PR, then smoke-tests the resulting
binary. This is the only way to catch a regression in build:sea
before someone downloads a broken binary.
While wiring this up: sea-config.json's output ("dist/hello", no
extension) isn't directly runnable on Windows. build-sea.js now
renames it to dist/hello.exe on win32 after the build -- the file is
already a valid PE binary at that point (it started as a copy of
node.exe), so a plain rename is enough.
Closes #8, closes #11.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8, closes #11
.github/workflows/ci.yml: installs, typechecks, tests, and builds the SEA binary on ubuntu-latest/macos-latest/windows-latest on every push to main and every PR, then smoke-tests the produced binary.sea-config.json'soutput(dist/hello, no extension) isn't directly runnable on Windows.build-sea.jsnow renames it todist/hello.exeon win32 after the build.Verified locally on macOS (arm64):
Windows/Linux paths are only actually validated by this PR's own CI run — waiting on that before merging.