Add Biome for linting and formatting - #18
Merged
Merged
Conversation
Adds @biomejs/biome with a config matching the existing style
(2-space indent, single quotes), `npm run lint`/`format` scripts, and
a lint job in CI. tsconfig.json and package-lock.json are excluded
from Biome's scope (auto-generated / heavily hand-aligned comments).
Fixing what the recommended ruleset flagged also touched actual code:
- require('fs') / require('child_process') -> node: protocol
- dropped an unused catch binding in build-sea.js
- Greeter, a static-only class, became a plain sayHello() function
(flagged by lint/complexity/noStaticOnlyClass); hello.ts and the
test were updated accordingly
Verified: tests pass, tsc compiles, full SEA build still works.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
@biomejs/biome(2-space indent, single quotes, matching the existing style),npm run lint/npm run format, and alintjob in CI.tsconfig.jsonandpackage-lock.jsonare excluded from Biome's scope (auto-generated / hand-aligned comments not worth reformatting).require('fs')/require('child_process')→node:protocolcatch (error)binding in build-sea.jsGreeter, a static-only class, became a plainsayHello()function (flagged bylint/complexity/noStaticOnlyClass) —hello.tsand the test were updated to matchVerified locally: tests pass,
tsccompiles clean, fullbuild:allstill produces a working binary.