Demo the SEA assets config option - #19
Merged
Merged
Conversation
Embeds assets/greeting.txt into the binary via sea-config.json and reads it back at runtime through node:sea's isSea()/getAsset() -- guarded so plain `npm start` (not a SEA) doesn't try to read it. Updates the README (project structure, example output, config options section) and prunes "Future Improvements" down to what's actually still open now that tests/CI/Biome exist. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Embeds
assets/greeting.txtinto the binary viasea-config.jsonand reads it back at runtime throughnode:sea'sisSea()/getAsset()— guarded sonpm start(plain ts-node, not a SEA) doesn't try to read it.Also updates the README (project structure, example output, config options section) and prunes "Future Improvements" down to what's actually still open now that tests/CI/Biome exist.
Verified locally: lint clean, tests pass,
npm startunaffected, and the built binary prints the embedded asset: