Skip to content

[SECURITY] Fix unauthenticated SSRF in frontend eID tx_dlf_pageview_proxy #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastian-meyer merged 1 commit into from
Oct 21, 2026
Merged

[SECURITY] Fix unauthenticated SSRF in frontend eID tx_dlf_pageview_proxy #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Classes/Eid/PageViewProxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,16 @@ protected function handleHead(ServerRequestInterface $request): ResponseInterfac
$queryParams = $request->getQueryParams();

$url = (string) ($queryParams['url'] ?? '');
if (!Helper::isValidHttpUrl($url)) {
return new JsonResponse(['message' => 'Did not receive a valid URL.'], 400);
}

// get and verify the uHash
$uHash = (string) ($queryParams['uHash'] ?? '');
if (!hash_equals(GeneralUtility::hmac($url, 'PageViewProxy'), $uHash)) {
return new JsonResponse(['message' => 'No valid uHash passed!'], 401);
}

$headers = [
'User-Agent' => $this->extConf['userAgent'] ?? 'Kitodo.Presentation'
];
Expand Down
2 changes: 1 addition & 1 deletion ext_emconf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
$EM_CONF[$_EXTKEY] = [
'title' => 'Kitodo.Presentation',
'description' => 'Base plugins, modules, services and API of the Digital Library Framework. It is part of the community-based Kitodo Digitization Suite.',
'version' => '5.0.10',
'version' => '5.0.11',
'category' => 'misc',
'constraints' => [
'depends' => [
Expand Down
Loading