phpinfo improvements

[pavetheway91]

• "Brotli support enabled" doesn't provide any information, so just remove it
• show if brotli is bundled or not
• show if brotli is the active serializer for apcu or if apcu isn't loaded
• rename serializer ABI to interface
• if apcu support wasn't built, show that it could have been built

Summary by CodeRabbit

• New Features

  • Extension information now displays the Brotli extension version, library source and version, dictionary support, and APCu serializer status.

• Bug Fixes

  • Improved diagnostic reporting for bundled or external Brotli libraries and APCu availability, including clearer configuration-specific status details.

• Tests

  • Expanded validation of extension details, library configuration, dictionary support, APCu states, MIME exclusions, and consistent diagnostic output.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c3449650-1384-4801-af65-07123b2e37ba

📥 Commits

Reviewing files that changed from the base of the PR and between 22e29d8 and 79b943c.

📒 Files selected for processing (1)

• tests/info.phpt

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/info.phpt

---

📝 Walkthrough

Walkthrough

The Brotli module information output now reports extension, library, and APCu serializer status. The information test captures this output and validates Brotli, dictionary, APCu, MIME, and fixed success-line results across configurations.

Changes

Brotli information reporting

Layer / File(s)	Summary
Module information status brotli.c	The module information output reports the extension version, Brotli library source and version, and APCu serializer status.
Information output validation tests/info.phpt	The test captures ReflectionExtension('brotli')->info() output and validates Brotli, dictionary, APCu, MIME, and fixed success-line results.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• kjdev/php-ext-brotli#69: Updates dictionary support reporting and validation.
• kjdev/php-ext-brotli#98: Modifies ZEND_MINFO_FUNCTION(brotli) module information output.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: improvements to the Brotli extension's phpinfo output.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/info.phpt`:
- Around line 72-98: Update the MIME-check section in tests/info.phpt to execute
validation before printing success: scan all entries in $lines for the “Built-in
output compression exclusions => ” row rather than using fixed indices, parse
its MIME values, report invalid values or a missing row as failures, and print
“MIMEs OK” only when the row exists and every MIME matches the expected format.
- Line 39: Update the assertion around the dictionary-status check in
tests/info.phpt to derive the expected enabled or disabled value from the
configured BROTLI_DICTIONARY_SUPPORT setting, then require an exact match
against $lines[3] instead of accepting either state.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aca54509-8114-48f3-995a-c8b7f2c7879d

📥 Commits

Reviewing files that changed from the base of the PR and between 7f962d4 and e990d20.

📒 Files selected for processing (2)

• brotli.c
• tests/info.phpt

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/info.phpt`:
- Around line 52-58: Update the loaded-APCu branch in tests/info.phpt to derive
the expected “brotli active” or “brotli inactive” value from
ini_get('apc.serializer') and require an exact match against $value, rather than
accepting either status.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c875259c-40f1-4b84-8b76-7c8dbb1e11c5

📥 Commits

Reviewing files that changed from the base of the PR and between 80884c9 and 22e29d8.

📒 Files selected for processing (2)

• brotli.c
• tests/info.phpt

🚧 Files skipped from review as they are similar to previous changes (1)

• brotli.c