fix(library): keep half-typed exclusion when switching form tabs - #1202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The library add/edit form's Scanner tab holds its "add exclusion" text field state locally. On iOS/macOS the form's sections are swapped by a segmented tab picker, so leaving the Scanner tab destroys the section view and any half-typed exclusion text with it. (Missed from the nit batch in #1201.)
Fix
Hoist
newExclusionfromLibraryFormScannerSectiontoLibraryFormSections, which persists across tab switches, and pass it down as a binding. No behavior change otherwise.Validation
make formatmake build— iOS, macOS, tvOS all pass